Add configuration option to `RedisCache` to allow read-only access
#38 046 ouverte le 3 nov. 2021
Métriques du dépôt
- Stars
- (37 933 stars)
- Métriques de merge PR
- (Merge moyen 16j 9h) (258 PRs mergées en 30 j)
Description
Currently, RedisCache resets expiry for keys on every read (https://github.com/dotnet/aspnetcore/blob/main/src/Caching/StackExchangeRedis/src/RedisCache.cs#L293 and in the async version as well).
When using Redis as a session storage, this can lead to sessions getting invalidated unnecessarily on Redis failover. During a new leader election read-only access is preserved which would allow existing clients to continue. However due to the EXPIRE command being issued alongside the read, the read command will fail.
This might be desired behaviour in other circumstances. For a session storage solution it would be fine to just ignore the exception on expire and carry on. In the case that Redis writes do not become available within expiry time, the session would then expire. It would also still expire when attempting other writes.
A configuration option for the cache would be nice to allow expire to fail. Otherwise, changing the variables in the class to protected so sensible overrides are possible might be another solution.