directus/directus

Support proxies for file storage adapters

Open

#24 381 ouverte le 10 janv. 2025

Voir sur GitHub
 (1 commentaire) (0 réactions) (0 assignés)TypeScript (25 193 stars) (3 505 forks)batch import
EngineHelp WantedImprovement

Description

Describe the Bug

While trying to upload a file to s3 on a machine where there is an environment variable for proxy, this is ignored by the httpAgent and httpsAgent, so the upload is always blocked, to solve this we swapped both agent for ProxyAgent, everything works the same but proxy variables are retrived and used correctly

+import { ProxyAgent } from "proxy-agent";
 var DriverS3 = class {
   config;
   client;
@@ -54,8 +53,8 @@ var DriverS3 = class {
       requestHandler: new NodeHttpHandler({
         connectionTimeout,
         socketTimeout,
-        httpAgent: new HttpAgent({ maxSockets, keepAlive }),
-        httpsAgent: new HttpsAgent({ maxSockets, keepAlive })
+        httpAgent: new ProxyAgent({ maxSockets, keepAlive }),
+        httpsAgent: new ProxyAgent({ maxSockets, keepAlive })
       })

To Reproduce

Try to upload a file to s3 through a machine that needs a proxy to make requests to external services

Directus Version

11.3.5

Hosting Strategy

Self-Hosted (Docker Image)

Database

No response

Guide contributeur

Stack technique
typescriptnodejsaws
Domaine
backend
Type d'issue
bug
DifficultéDifficulté estimée pour un nouveau contributeur, de 1 pour un très petit changement à 5 pour un travail expert.
2
Temps estiméFourchette de temps approximative pour investiguer, implémenter, tester et préparer une pull request.
under 1 hour
Statut d'activitéDisponibilité apparente de l'issue : fraîche, active, ancienne, bloquée ou en attente d'un mainteneur.
fresh
ClartéClarté avec laquelle l'issue explique le changement attendu, les critères d'acceptation et la prochaine étape.
clear
Prérequis
Node.jsAWS S3
Accessibilité débutantScore de 1 à 100 estimant l'accessibilité de cette issue pour un premier contributeur.
80
Direction de recherche
The issue describes a bug where file uploads to S3 fail on machines requiring a proxy. The fix involves replacing the default HttpAgent and HttpsAgent with ProxyAgent from the 'proxy agent' package in the S3 driver. Look for the file that defines the S3 file storage adapter (likely in `src/drivers/s3.ts` or similar). The change is shown in the issue body. Ensure that 'proxy agent' is added as a dependency. No linked PRs or assignees exist, so the issue is available.