diasurgical/DevilutionX

Replace "int x, int y" arguments with "Point point"

Ouverte

#1 684 ouverte le 25 avr. 2021

 (2 commentaires) (1 réaction) (0 personne assignée)C++ (743 forks)batch import
good first issuehelp wanted

Métriques du dépôt

Stars
 (7 255 étoiles)
Métriques de merge PR
 (Merge moyen 2j 12h) (15 PRs mergées en 30 j)

Description

A lot of functions take two ints as the coordinates for their operations, this is both verbose and error-prone. Instead we should use the Point structure, see an example of this type of cleanup done for the GetDirection() https://github.com/diasurgical/devilutionX/commit/f77c52941afd73d4e734c0696d082218cd04c3a7

Try to split the changes up in one function per commit to making it easy to review and less prone to typos.

Guide contributeur