dOrgTech/DAOcreator

`initStateStore` - Don't Assume LocalStorage

Ouverte

#243 ouverte le 17 nov. 2019

 (0 commentaire) (0 réaction) (0 personne assignée)TypeScript (18 forks)auto 404
Libcode improvementgood first issuemed pri

Métriques du dépôt

Stars
 (34 étoiles)
Métriques de merge PR
 (Métriques PR en attente)

Description

Currently we've hard-coded our state persistence into the UI layer and are using the localStorage of the browser. We should instead be making API calls into the Lib layer, and using an interface the implementer of the library supplies upon initialization.

For example:

import { initStateStore } from "lib/state";

// localStorage in browser, file in CLI
setStateStore({
  getItem: (key: string) => { ... },
  setItem: (key: string, value: string) => { ... },
  clearItem: (key: string) => { ... }
});

// later in the application
getSavedDAO();
saveDAO(dao);

Guide contributeur