cssinjs/jss

[jss-compose] When composing from a class that takes props, the inheriting class needs props also

Open

#1 319 ouverte le 22 mars 2020

Voir sur GitHub
 (1 commentaire) (0 réactions) (0 assignés)JavaScript (434 forks)batch import
bughelp wanted

Métriques du dépôt

Stars
 (7 000 stars)
Métriques de merge PR
 (Aucune PR mergée en 30 j)

Description

I have a class that takes props, when I extend it, the extension doesn't work unless the class that extends also takes props.

const useStyles = makeStyles({
  icon: props => ({ // <---------- base class
    fontSize: Number(props.size)
  }),
  successIcon: props => ({
    composes: '$icon', // This works, because it takes props, even though not using them
    color: 'green'
  }),
  failIcon: {
    composes: '$icon',  // This extension should work, but it doesn't
    color: 'red'
  }
})

React-JSS 10.1.1 Material UI 4.9.7

Guide contributeur