community-shaders/skyrim-community-shaders
Voir sur GitHubInvestigate hardcoded offset for enableWaterTAA in BSImagespaceShaderISTemporalAA
Open
#1 727 ouverte le 17 janv. 2026
help wanted
Métriques du dépôt
- Stars
- (1 037 stars)
- Métriques de merge PR
- (Merge moyen 2j 4h) (63 PRs mergées en 30 j)
Description
Description
The code currently uses a hardcoded memory offset (0x38LL) to access the enableWaterTAA member in the BSImagespaceShaderISTemporalAA structure:
bool* enableWaterTAA = reinterpret_cast<bool*>(reinterpret_cast<uintptr_t>(BSImagespaceShaderISTemporalAA) + 0x38LL);
Location: src/Features/Upscaling.cpp:705
Tasks
- Investigate if CommonLibSSE/CommonLibVR has already reverse engineered the
BSImagespaceShaderISTemporalAAstructure. We use the ng branch of commonlibvr. - If available in CommonLib, refactor to use the proper structure member instead of hardcoded offset
- If not available, perform RE work to properly define the structure
- Document the structure definition for maintainability
Context
Hardcoded offsets are fragile and can break with game updates or across different game versions. Using proper structure definitions from CommonLib (if available) or creating our own RE definitions would make this code more maintainable.
References
- PR: https://github.com/doodlum/skyrim-community-shaders/pull/1726
- Comment: https://github.com/doodlum/skyrim-community-shaders/pull/1726#discussion_r2700756452
- Requested by: @alandtse