client9/shlib

logging functionality

Ouverte

#10 ouverte le 8 mars 2018

 (0 commentaire) (0 réaction) (0 personne assignée)Shell (40 forks)github user discovery
enhancementhelp wanted

Métriques du dépôt

Stars
 (430 étoiles)
Métriques de merge PR
 (Aucune PR mergée en 30 j)

Description

Much of the code uses echo as way of returning results or a partial result in a pipe.

Other times echo is used as a logging mechanism, and inconsistently.

Here are two examples of the later:

uname_os_check.sh:  echo "$0: uname_os_check: internal error '$(uname -s)' got converted to '$os' which is not a GOOS value. Please file bug at https://github.com/client9/shlib"
untar.sh:      echo "Unknown archive format for ${tarball}"

Both also go to stdout, not stderr.

Better would be to have a function that does logging.

Thinking

log_error
log_info
log_debug
log_prefix 

The last one would be a function that would emit a common prefix. A function so smart people could completely over-ride it and add a date or whatever, but by default it would be:

log_prefix() {
  echo $0  or nothing ""
}

Also need some way of setting the level. Will need to see what syslog and friends do.

n

Guide contributeur