chroma-core/chroma

[CLN] Break up test_api

Ouverte

#2 586 ouverte le 28 juil. 2024

 (4 commentaires) (0 réaction) (1 personne assignée)Rust (2 247 forks)batch import
by-chromacleanupgood first issue

Métriques du dépôt

Stars
 (27 958 étoiles)
Métriques de merge PR
 (Merge moyen 1j 16h) (80 PRs mergées en 30 j)

Description

test_api.py is a legacy of Chroma's launch, and provided some basic initial test coverage. We've continued to add to it as the project has evolved, and it's become a catch-all kitchen sink test file.

In practice a lot of the surface covered in test_api is better covered by our property tests. test_api.py should be broken up into separate files by API / object, and each object test should cover exceptional cases, rather than normal operation.

For example, we should save entropy in the property tests by not having them generate lists of IDs that are shorter than the lists of documents on a Collection.add call, but we should also be testing this path.

Guide contributeur