bytecodealliance/wasmtime
Eagerly cast pointers in aarch64 relocation code to `usize` to avoid `unsafe` blocks in cranelift-jit
Fermée
#7 588 ouverte le 27 nov. 2023
good first issue
Métriques du dépôt
- Stars
- (17 002 étoiles)
- Métriques de merge PR
- (Merge moyen 23h 31m) (212 PRs mergées en 30 j)
Description
When performing relocations in cranelift-jit, there are many introductions of a variable what that's defined as an unsafe pointer offset. These variables are almost always cast to usize or isize before they're used, so perhaps we should instead turn the base pointer into its target numeric type eagerly, to avoid needing the unsafe blocks for calling the offset method on the pointers.