bitovi/funcunit

Dynamic iframes are considered not loaded

Open

#139 ouverte le 24 févr. 2016

Voir sur GitHub
 (1 commentaire) (0 réactions) (0 assignés)JavaScript (395 forks)batch import
bughelp wantedp2

Métriques du dépôt

Stars
 (575 stars)
Métriques de merge PR
 (Aucune PR mergée en 30 j)

Description

If I create an <iframe>, populate it dynamically, and set it as the context for FuncUnit like this:

var iframe = $(document.createElement('iframe'));
iframe.contents().find('body').append(frag);    
F.open(win);

All tests will fail because FuncUnit.documentLoaded() will return false here: https://github.com/bitovi/funcunit/blob/01f767b1e95737a7dfcae1f67a75b4d72408ba37/browser/getters.js#L509

Due to the fact that FuncUnit.win.location.href === 'about:blank' here: https://github.com/bitovi/funcunit/blob/92fd4b283388576922506fb76096902c8f9183bf/browser/open.js#L258-L260

To get around this I had to overwrite FuncUnit.documentLoaded to always return true like this:

F.documentLoaded = function () { return true; };

Guide contributeur