beautifier/js-beautify

Handlebars {{#tr}} helper is indented as if it were a <tr> tag

Open

#2 045 ouverte le 13 avr. 2022

Voir sur GitHub
 (6 commentaires) (0 réactions) (0 assignés)JavaScript (8 342 stars) (1 460 forks)batch import
good first issuelanguage: htmltype: bug

Description

Description

Zulip defines a custom Handlebars helper {{#tr}} for translation, but when it happens to be used inside a table cell, js-beautify seemingly confuses it with a <tr> (table row) tag and indents it at the wrong level.

Input

The code looked like this before beautification:

<table>
    <tr>
        <td>
            {{#tr}}translated{{/tr}}
        </td>
    </tr>
</table>

Expected Output

The code should have looked like this after beautification:

<table>
    <tr>
        <td>
            {{#tr}}translated{{/tr}}
        </td>
    </tr>
</table>

Actual Output

The code actually looked like this after beautification:

<table>
    <tr>
        <td>
    {{#tr}}translated{{/tr}}
    </td>
    </tr>
</table>

Steps to Reproduce

html-beautify -H test.hbs

Environment

OS: Linux

Settings

None

Guide contributeur

Stack technique
javascripthtml
Domaine
toolingdeveloper experience
Type d'issue
bug
DifficultéDifficulté estimée pour un nouveau contributeur, de 1 pour un très petit changement à 5 pour un travail expert.
2
Temps estiméFourchette de temps approximative pour investiguer, implémenter, tester et préparer une pull request.
1-3 hours
Statut d'activitéDisponibilité apparente de l'issue : fraîche, active, ancienne, bloquée ou en attente d'un mainteneur.
stale
ClartéClarté avec laquelle l'issue explique le changement attendu, les critères d'acceptation et la prochaine étape.
clear
Prérequis
HTMLJavaScriptHandlebars basics
Accessibilité débutantScore de 1 à 100 estimant l'accessibilité de cette issue pour un premier contributeur.
75
Direction de recherche
Start by reviewing the issue description and the linked template file (static/templates/search operators.hbs). The likely root cause is in the HTML tokenizer of js beautify, where {{#tr}} is mistakenly classified as a <tr> tag. Examine the tokenization and indentation logic in the JavaScript source code, specifically how custom tags or Handlebars helpers are handled. Consider implementing a check for Handlebars block helpers that start with # to prevent them from being treated as HTML tags.