[Bug]: Support a partial last block group to avoid expanding the EXT4 filesystem size · apple/containerization#647

Métriques du dépôt

Stars: (8 542 stars)
Métriques de merge PR: (Merge moyen 9j 15h) (21 PRs mergées en 30 j)

Description

I have done the following

I have searched the existing issues
If possible, I've reproduced the issue using the 'main' branch of this project

Steps to reproduce

Create an EXT4 filesystem with 160 MiB:

container volume create -s 160M size-test
stat -f%z ~/Library/Application\ Support/com.apple.container/volumes/size-test/volume.img

Current behavior

When creating an EXT4 filesystem, the requested size is expanded to the nearest block group boundary. A filesystem whose requested size falls between two block group boundaries ends up larger than requested - 256 MiB:

268435456

Expected behavior

The fix is to support a partial last block group so the filesystem uses exactly the requested size - 160 MiB:

167772160

Environment

N/A

Relevant log output

N/A

Code of Conduct

I agree to follow this project's Code of Conduct

Guide contributeur

Direction de recherche: Examinez le code de creation du systeme de fichiers EXT4 dans le projet containerization pour prendre en charge un dernier groupe de blocs partiel. Concentrez vous sur la facon dont les limites des groupes de blocs sont calculees et modifiez l'allocation pour utiliser exactement la taille demandee.
Stack technique: swift
Domaine: backend
Type d'issue: Bug
Difficulté: 2
Temps estimé: 1-3 heures
Statut d'activité: Active
Clarté: Claire
Prérequis: Git
Accessibilité débutant: 65