angular-ui/ui-grid
Voir sur GitHubGrouppriority default treeAggregationFn overwrite bug
Open
#5 123 ouverte le 16 févr. 2016
good first issuegrid-grouping
Métriques du dépôt
- Stars
- (5 395 stars)
- Métriques de merge PR
- (Aucune PR mergée en 30 j)
Description
According to the docs the groupingColumnBuilder function should get one of the default aggregations when the groupPriority is undefined or less then 0, however, in the code it does otherwise:
If the groupPriority is undefined or less than 0, then we expect to be aggregating, and we look at the aggregation types to determine what sort of aggregation we can do. Values are in the constants file, but include SUM, COUNT, MAX, MIN
if ( typeof(col.grouping.groupPriority) !== 'undefined' && col.grouping.groupPriority > -1 ){
col.treeAggregationFn = uiGridTreeBaseService.nativeAggregations()[uiGridGroupingConstants.aggregation.COUNT].aggregationFn;
col.treeAggregationFinalizerFn = service.groupedFinalizerFn;
}
As you see in the above code, it actually checks for !== 'undefined' && > -1, which overwrites a possible custom set treeAggregationFn with a default one.
This above code is taken from the current release, line #18959