angular-fullstack/generator-angular-fullstack

Error with PUT with Sequelize Backend

Open

#2 180 ouverte le 26 août 2016

Voir sur GitHub
 (4 commentaires) (0 réactions) (0 assignés)JavaScript (6 134 stars) (1 268 forks)batch import
Help WantedV4bug

Description

  • I understand that GitHub issues are not for tech support, but for questions specific to this generator, bug reports, and feature requests.
Item Version
generator-angular-fullstack 4.0.1
Node 4.4.5
npm 3.10.5
Operating System OS X 10
Item Answer
Transpiler Babel
Markup HTML
CSS SCSS
Router ui-router
Client Tests Mocha
DB SQL
Auth N

Hey,

It appears the Mocha PUT tests / Upsert Functionality for the Sequelize backend are broken.

The test expects the object back when according to the Sequelize documentation it only return a true or a false. http://docs.sequelizejs.com/en/latest/api/model/#upsertvalues-options-promisecreated

Although in my case I get undefined... which causes it to not return anything and breaks the backend route entirely. I think it might be because I'm using Postgres... I was able to modify the backend code fine to get around it. but figured I should raise it anyways.

Guide contributeur

Stack technique
javascriptnodejsexpresssql
Domaine
backend
Type d'issue
bug
DifficultéDifficulté estimée pour un nouveau contributeur, de 1 pour un très petit changement à 5 pour un travail expert.
3
Temps estiméFourchette de temps approximative pour investiguer, implémenter, tester et préparer une pull request.
1-3 hours
Statut d'activitéDisponibilité apparente de l'issue : fraîche, active, ancienne, bloquée ou en attente d'un mainteneur.
stale
ClartéClarté avec laquelle l'issue explique le changement attendu, les critères d'acceptation et la prochaine étape.
clear
Prérequis
Sequelize basicsMocha testingExpress route handlingUnderstanding of PUT endpoints
Accessibilité débutantScore de 1 à 100 estimant l'accessibilité de cette issue pour un premier contributeur.
65
Direction de recherche
Examine the test file for PUT endpoint (likely 'server/api/thing/thing.spec.js') and the corresponding route handler. The issue reports that the test expects an object from Sequelize's upsert, but it returns true/false. Search the codebase for the upsert call and test expectations. Refer to issue comments for additional context. Modify the test to expect a boolean or adjust the route to return the correct value.