akka/akka-http

Split package `akka.http.ccompat`

Open

#2 902 ouverte le 20 janv. 2020

Voir sur GitHub
 (3 commentaires) (0 réactions) (0 assignés)Scala (598 forks)batch import
1 - triagedbinary-incompatiblediscusshelp wantednice-to-have (low-prio)

Métriques du dépôt

Stars
 (1 311 stars)
Métriques de merge PR
 (Merge moyen 1h 17m) (1 PR mergée en 30 j)

Description

This is a follow-up to https://github.com/akka/akka/issues/28304#issuecomment-576360895.

The two artifacts akka.parsing and akka.http.core. both in version 10.1.11, contain (disjunct) classes in the Java package akka.http.ccompat. A split package is considered bad practice, even in plain Java world. Split packages are even not possible when working with sealed packages/jars.

As we currently review the OSGi support for akka and akka-http in a separate project (as a consequence of https://github.com/akka/akka/issues/28304), we wanted to ask the purpose of the found split package. If this is "by accident", I'd like to propose one of the following fixes:

  1. Move all classes to the same package into the same artifact
  2. Rename one of the packages to avoid the split-package issue, preferably choosing a package name which shares the artifact name as it's prefix
  3. Keep it as-is. I think this way should be avoided, but could be necessary e.g. when the packages are part of a public API. But even then, maybe 1. will also work.

Related to https://github.com/woq-blended/akka-osgi/issues/1

Guide contributeur