akiran/react-slick

waitForAnimate={false} not working as expected

Open

#1 415 ouverte le 31 oct. 2018

Voir sur GitHub
 (2 commentaires) (12 réactions) (0 assignés)JavaScript (11 386 stars) (2 109 forks)batch import
good first issue

Description

When setting waitForAnimate to false I want to be able to swipe through the next slide, before the animation finishes. The animation currently doesn't seem to change any behaviour of swiping and animating.

This is important for mobile when you want the user to have a smooth swiping experience that's as fast as possible.

Sandbox: https://3vvzvzl325.codesandbox.io/ (Just swipe very fast through the slides and you'll notice you always have to wait for the current slide animation to finish until you can swipe to the next one)

Guide contributeur

Stack technique
javascriptreact
Domaine
frontend
Type d'issue
bug
DifficultéDifficulté estimée pour un nouveau contributeur, de 1 pour un très petit changement à 5 pour un travail expert.
3
Temps estiméFourchette de temps approximative pour investiguer, implémenter, tester et préparer une pull request.
half day
Statut d'activitéDisponibilité apparente de l'issue : fraîche, active, ancienne, bloquée ou en attente d'un mainteneur.
stale
ClartéClarté avec laquelle l'issue explique le changement attendu, les critères d'acceptation et la prochaine étape.
mostly clear
Prérequis
React basicsUnderstanding of animation logic
Accessibilité débutantScore de 1 à 100 estimant l'accessibilité de cette issue pour un premier contributeur.
50
Direction de recherche
Investigate the `waitForAnimate` prop implementation in the react slick component. Focus on the animation callback flow: likely in the main slider component (e.g., src/slider.js) and how swipe events interact with the animation state. The issue is that setting `waitForAnimate={false}` should allow swiping before animation finishes, but currently it doesn't. Check if the prop is properly passed to internal methods and if there's a missing early return or state reset. Refer to the sandbox for reproduction.