adobe/spectrum-web-components
[Bug]: Coachmark step count is not localized
Ouverte
#4 780 ouverte le 24 sept. 2024
Component:CoachmarkFeatureGood first issueSEV 3i18n
Métriques du dépôt
- Stars
- (1 525 étoiles)
- Métriques de merge PR
- (Métriques PR en attente)
Description
Code of conduct
- I agree to follow this project's code of conduct.
Impacted component(s)
Coachmark
Expected behavior
In the Coachmark component the step count, for example "1 of 3" has hardcoded the "of" string. The expected behavior is that this string is localized, or is at least configurable so the client can pass in the string to use in this case.
Actual behavior
The "of" word is hardcoded.
Screenshots
What browsers are you seeing the problem in?
Chrome
How can we reproduce this issue?
Bug was discovered in a pre-release version so I can't share my own reproduction steps, as the feature has not been publicly released. But this surely reproduces anywhere Coachmark component is used.
- Change language to non-english
- Enter multi-step coachmark tour Code where this is hard-coded is here https://github.com/adobe/spectrum-web-components/blob/a2b6bea7142930d8143d9ca887e2c56ffa71a669/packages/coachmark/src/Coachmark.ts#L278
Sample code or abstract reproduction which illustrates the problem
No response
Severity
SEV 3
Logs taken while reproducing problem
No response