VSCodeVim/Vim

Repeating `gb` once when selecting Multi-Cursors means subsequent `gb` are repeated that amount

Open

#4 075 ouverte le 15 sept. 2019

Voir sur GitHub
 (0 commentaires) (2 réactions) (0 assignés)TypeScript (12 664 stars) (1 271 forks)batch import
area/multicursorhelp wantedkind/bug

Description

Describe the bug If you use gb with a number, subsequent uses of gb are repeated that same amount. Eg 10gb gb would result in 20 cursors, not 11.

Similarly, if I do gb, 10gb, gb, I get 21 cursors instead of 12.

To Reproduce

Lets say I have 10 lines, each with the same single word

vim
vim
...
vim
vim

Scenario A) I put a cursor on the first line, and in normal mode do 5gb then gb.

Scenario B) I put a cursor on the first line, and in normal mode do gb, 5gb, gb.

Expected behavior Scenario A) I would expect 6 cursors but there are 10.

Scenario B) I would expect 7 cursors but there are 10 (there would be 11 if there were more lines).

Screenshots

Reproduction Steps Screenshot

Environment (please complete the following information):

  • Issue Type: Bug
  • Extension Name: vim
  • Extension Version: 1.10.2
  • OS Version: Linux x64 5.2.14-arch2-1-ARCH
  • VSCode version: 1.38.0

Additional context N/A

Guide contributeur

Stack technique
typescriptjavascript
Domaine
developer experience
Type d'issue
bug
DifficultéDifficulté estimée pour un nouveau contributeur, de 1 pour un très petit changement à 5 pour un travail expert.
2
Temps estiméFourchette de temps approximative pour investiguer, implémenter, tester et préparer une pull request.
1-3 hours
Statut d'activitéDisponibilité apparente de l'issue : fraîche, active, ancienne, bloquée ou en attente d'un mainteneur.
fresh
ClartéClarté avec laquelle l'issue explique le changement attendu, les critères d'acceptation et la prochaine étape.
clear
Prérequis
Basic understanding of Vim keybindingsFamiliarity with TypeScriptKnowledge of multi cursor operations
Accessibilité débutantScore de 1 à 100 estimant l'accessibilité de cette issue pour un premier contributeur.
65
Direction de recherche
The bug is in the 'gb' command implementation, likely in the actions/commands folder. The issue is that using a count with 'gb' sets a multiplier that persists across subsequent 'gb' calls. Inspect how count is handled in the command execution, particularly in the command class for 'gb'. The fix likely involves resetting the count after each invocation or not storing it globally.