VSCodeVim/Vim

easymotion j/k not triggering prompts on empty lines

Open

#2 388 ouverte le 16 févr. 2018

Voir sur GitHub
 (1 commentaire) (2 réactions) (0 assignés)TypeScript (12 664 stars) (1 271 forks)batch import
area/pluginhelp wantedkind/bug

Description

Is this a BUG REPORT or FEATURE REQUEST? (choose one): in the sense that the behavior of VSCode easymotion deviates from vim easymotion, I would categorize this as a bug.

What happened: when using <leader><leader>j or <leader><leader>k, empty lines do not have prompts included for them. For example:

What did you expect to happen: these motions should trigger prompts even on new lines. See the behavior in vim:

How to reproduce it (as minimally and precisely as possible): <leader><leader>j or k on a file with blank lines; observe that no prompts appear for the empty lines.

Environment:

  • Extension (VsCodeVim) version: 0.10.13
  • VSCode version: Version 1.20.1
  • OS version: OS X 10.13.3

Guide contributeur

Stack technique
typescript
Domaine
frontenddeveloper experience
Type d'issue
bug
DifficultéDifficulté estimée pour un nouveau contributeur, de 1 pour un très petit changement à 5 pour un travail expert.
3
Temps estiméFourchette de temps approximative pour investiguer, implémenter, tester et préparer une pull request.
1-3 hours
Statut d'activitéDisponibilité apparente de l'issue : fraîche, active, ancienne, bloquée ou en attente d'un mainteneur.
stale
ClartéClarté avec laquelle l'issue explique le changement attendu, les critères d'acceptation et la prochaine étape.
clear
Prérequis
TypeScriptVSCode extension developmentEasymotion plugin logic
Accessibilité débutantScore de 1 à 100 estimant l'accessibilité de cette issue pour un premier contributeur.
70
Direction de recherche
Investigate the easymotion implementation in the VSCodeVim extension, likely in the `src/actions/easymotion.ts` file. Focus on how prompts (labels) are generated for lines, specifically why empty lines are skipped. Check the function that creates marks for line motions and see if there is a filter that excludes empty lines. Look at the original Vim easymotion behavior for reference. The issue has one comment that may contain additional insights; review it for any proposed fix or discussion.