Métriques du dépôt
- Stars
- (38 153 stars)
- Métriques de merge PR
- (Merge moyen 9j 17h) (17 PRs mergées en 30 j)
Description
Checklist
- I checked, but didn't find any duplicates (open OR closed) of this issue in the repo.
- I have read the contribution guidelines given at https://github.com/TeamNewPipe/NewPipe/blob/HEAD/.github/CONTRIBUTING.md.
- This issue contains only one feature request. I will open one issue for every feature I want to request.
Describe the feature you want
Currently, NewPipe determines whether tabled mode should be used based whether the smallest width is <480dp or >=480dp.
According to the the Android developer guide (https://developer.android.com/training/multiscreen/screensizes) the breakpoint should be at 600dp. They have the following quantifiers there:
- 320dp: a typical phone screen (240x320 ldpi, 320x480 mdpi, 480x800 hdpi, etc).
- 480dp: a large phone screen ~5" (480x800 mdpi).
- 600dp: a 7” tablet (600x1024 mdpi).
- 720dp: a 10” tablet (720x1280 mdpi, 800x1280 mdpi, etc).
This is also consistent with e.g. the Android System UI, which switches into tablet mode at a smallest width of >=600dp.
Is your feature request related to a problem? Please describe it
I run my phone with a smallest width of ~500dp. This defaults NewPipe into tablet mode. PR #6059 fixes the problem for me, but I think the automatic tablet mode threshold is not where it should be.
How will you/everyone benefit from this feature?
This is a really small fix (literally just change a number) and causes phones with larger screens to be detected as phones. I am pretty sure there is no tablet out there with a (default) smallest width of <600dp.