Semantic-Org/Semantic-UI-React

Popup: Incorrect position of arrow

Open

#3 771 ouverte le 2 sept. 2019

Voir sur GitHub
 (7 commentaires) (7 réactions) (0 assignés)JavaScript (13 136 stars) (4 065 forks)batch import
bughelp wantedneeds engineering

Description

Bug Report

Steps

  1. Create an element with a popup
  2. Move that element to the right side of the page

Expected Result

I don't know an exact position of a trigger element on a page in advance but I expect popup and popup arrow will be displayed correctly everywhere as it was in 0.86.0. old

Actual Result

Popup arrow position is incorrect. The package doesn't calculate a popup position based on an actual popup trigger position. It passes down a position from props to popper and applies css styles based on that instead of calculating a correct value. In the previous version a position was changed to 'top right' but in current version it's 'top left' from defaultProps always. new

Version

0.88.0

Testcase

https://codesandbox.io/s/semantic-ui-react-o7mfd

Guide contributeur

Stack technique
reactjavascript
Domaine
frontend
Type d'issue
bug
DifficultéDifficulté estimée pour un nouveau contributeur, de 1 pour un très petit changement à 5 pour un travail expert.
3
Temps estiméFourchette de temps approximative pour investiguer, implémenter, tester et préparer une pull request.
1-3 hours
Statut d'activitéDisponibilité apparente de l'issue : fraîche, active, ancienne, bloquée ou en attente d'un mainteneur.
stale
ClartéClarté avec laquelle l'issue explique le changement attendu, les critères d'acceptation et la prochaine étape.
clear
Prérequis
React basicsCSS positioningPopup component knowledge
Accessibilité débutantScore de 1 à 100 estimant l'accessibilité de cette issue pour un premier contributeur.
55
Direction de recherche
The bug is in the Popup component's positioning logic. The issue provides a CodeSandbox testcase (https://codesandbox.io/s/semantic ui react o7mfd). The maintainers need to investigate why the position prop is not being recalculated based on the trigger element's actual position, as it was in version 0.86.0. Likely related files are `src/modules/Popup` and the positioning utility.