ProjectEvergreen/greenwood

update Greenwood to address all (as many) TypeScript no check comments

Ouverte

#1 427 ouverte le 1 mars 2025

 (0 commentaire) (0 réaction) (0 personne assignée)JavaScript (15 forks)auto 404
CLITypes(cript)enhancementgood first issue

Métriques du dépôt

Stars
 (132 étoiles)
Métriques de merge PR
 (Merge moyen 25j 20h) (29 PRs mergées en 30 j)

Description

Current State

Coming out of https://github.com/ProjectEvergreen/greenwood/pull/1420, a handful of // @ts-nocheck comments were sprinkled around the codebase, mostly dealing with ASTs and the like. Would be nice to give it a go and see if we can resolve as many of them as possible.

Desired State

We'll need to add JS files to tsconfig.json#include

{
  "include": ["./packages/*/src/types/*.d.ts", "./*.ts", "./packages/*/src/*.js"],
}

Then removal as many // @ts-nocheck comments and fix as many issue as possible from running yarn lint:types, e..g

Found 15 errors in 9 files.

Errors  Files
     4  packages/cli/src/loader.js:9
     3  packages/init/src/index.js:35
     1  packages/init/src/util.js:28
     1  packages/plugin-adapter-aws/src/index.js:128
     1  packages/plugin-adapter-netlify/src/index.js:174
     1  packages/plugin-adapter-vercel/src/index.js:149
     2  packages/plugin-css-modules/src/index.js:84
     1  packages/plugin-google-analytics/src/index.js:55
     1  packages/plugin-import-commonjs/src/index.js:63
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for

Additional Context

No response

Guide contributeur