feign-mock is too strict with request headers when matching requests
#1 552 ouverte le 20 déc. 2021
Métriques du dépôt
- Stars
- (9 070 stars)
- Métriques de merge PR
- (Merge moyen 2j 17h) (71 PRs mergées en 30 j)
Description
I am using https://github.com/OpenFeign/feign/tree/master/mock to write unit tests. When one would want to match/verify request headers, the current implementation seems too strict as it checks for exact equality. Ideally, it should be matching a subset of the headers as there can be headers the tester doesn't care about or generated headers like Content-Length.
I know the workaround for this is to write a RequestInterceptor and do assertions there, but that is not ideal as it adds a lot of boilerplate code in tests. For each test, one needs to write a test-specific RequestInterceptor.
I would like to propose making the header matching in RequestKey.java#L171 match a subset of the headers instead of exact equality.
Bonus Request: match with RegEx