OpenAPITools/openapi-diff

`--state` option outputs `metadata`

Open

#508 ouverte le 18 avr. 2023

Voir sur GitHub
 (0 commentaires) (0 réactions) (0 assignés)Java (187 forks)user submission
good first issue

Métriques du dépôt

Stars
 (1 079 stars)
Métriques de merge PR
 (Aucune PR mergée en 30 j)

Description

From help,

    --state                     Only output diff state: no_changes,
                                incompatible, compatible

this doesn't align with reality. We had a case where the state outputted metadata.

Caused by this line: https://github.com/OpenAPITools/openapi-diff/blob/1de574d3ca447bc463740bc10c37851702974a00/cli/src/main/java/org/openapitools/openapidiff/cli/Main.java#L203

We can simply https://github.com/OpenAPITools/openapi-diff/blob/1de574d3ca447bc463740bc10c37851702974a00/core/src/main/java/org/openapitools/openapidiff/core/model/DiffResult.java#L5

to include something like

public DiffResult toStateDiff() {
  if (this.isUnchanged()) {
    return DiffResult.UNCHANGED;
  }

 if (this.isCompatible()) {
    return DiffResult.COMPATIBLE;
 }

 return DiffResult.INCOMPATIBLE;
}

Guide contributeur