Blocked popups are not handled in Chrome on Github Codespace
#165 339 ouverte le 3 nov. 2022
Métriques du dépôt
- Stars
- (74 848 stars)
- Métriques de merge PR
- (Merge moyen 11h 43m) (1 000 PRs mergées en 30 j)
Description
When using GitHub Codespaces, if an extension tries to spawn a new browser window it's blocked by Chrome:
This issue was discussed in the context of Safari in #118731 and it seems like a fix was applied (that detects the blocking, then prompts the user so that the window can be re-triggered from a user-click which would not trigger the blocking), but from the discussion it's not clear if this was only applied to Safari (@isidorn may be able to confirm - I can't see anything Safari specific in the linked commits I reviewed). I certainly don't see that notification in Chrome.
The API called that triggered this was vscode.env.openExternal. It was tested today on the current live version of GitHub workspaces (and latest stable version of Chrome).
If I allow github.dev to spawn popups in Chrome settings, ofcourse everything works fine - but that only solves the problem for me and not other users.