Microsoft/TypeScript

Inferred Promise type breaks ordering of completions

Open

#56 978 ouverte le 8 janv. 2024

Voir sur GitHub
 (0 commentaires) (0 réactions) (0 assignés)TypeScript (6 726 forks)batch import
Domain: LS: Completion ListsExperience EnhancementHelp WantedSuggestion

Métriques du dépôt

Stars
 (48 455 stars)
Métriques de merge PR
 (Merge moyen 6j 17h) (9 PRs mergées en 30 j)

Description

🔎 Search Terms

promise, generic, completion, inference

🕗 Version & Regression Information

  • This is the behavior in every version I tried, and I reviewed the FAQ for entries about promise/completions (found nothing)

⏯ Playground Link

https://www.typescriptlang.org/play?#code/JYOwLgpgTgZghgYwgAgGIHt0B4AqA+ZCAD0hABMBnZABSnQFtgKJcCBvAKGWQHofkcACybIKg9AFcANmVHiA7sgkAHZDGBQKYZHCnoQAc2TzgYQcgRwwCQQBpkZiCHvqQuqQE97EawDouapgAFACUAFzIINJSANwcAL4cHFI+yAaYZBEY2ADaALp4cRx8yACSIMgAagDKyADC6GQQ9mBQHg4eyqAGYcU8fdxpGf5JMBIgCGDA+sgARnBkrEFEETjhaJisyJzcUD4SUBVRUlI6VHAgHnGJSSXlVbUNTS1tHV2GvXwD3PNkQfkhXxAA

💻 Code

interface Foo<T> extends Promise<T> {
  // This should show up first along with catch, then, finally, etc.
  foo(): null;
}

let good: Foo<[]>;

async () => {
  // In VS Code, try typing:
  //
  //   good.
}

function bad<T>(x: T): Foo<T> {
  return null as any;
}


async () => {
  // In VS Code, try typing:
  //
  //   bad([]).
}

🙁 Actual behavior

If a generic is used to infer the type contained in the Promise, then the completions ordering is lost.

This is the correct ordering, foo shows up towards the top: Screenshot 2024-01-07 at 20 22 06

But if the function returning the Promise subclass is used, the ordering is lost: Screenshot 2024-01-07 at 20 22 58

🙂 Expected behavior

The methods declared on the Promise and its subclasses / subinterfaces should show up before the "after adding await" properties of whatever is contained in the Promise.

Additional information about the issue

I'd be willing to work on fixing this with some guidance, if it's feasible.

Guide contributeur