Microsoft/TypeScript

Contextual type doesn't apply to elements of array literal spread into another array literal

Open

#45 600 ouverte le 27 août 2021

Voir sur GitHub
 (2 commentaires) (1 réaction) (0 assignés)TypeScript (6 726 forks)batch import
BugDomain: check: Contextual TypesEffort: ModerateHelp Wanted

Métriques du dépôt

Stars
 (48 455 stars)
Métriques de merge PR
 (Merge moyen 6j 17h) (9 PRs mergées en 30 j)

Description

Bug Report

🔎 Search Terms

spread operator, type inference

🕗 Version & Regression Information

  • This is the behavior in every version I tried

⏯ Playground Link

Playground link with relevant code

💻 Code

interface Test {
    field: 'a' | 'b' | 'c'
}

let arr: Test[] = [
    { field: 'c' },
    ...[
        { field: 'a' }, // field: string
//        ^?
        { field: 'b' }, // field: string
//        ^?
    ]
]

function test(...args: Test[]): void {}

test(
    { field: 'c' },
    ...[
        { field: 'a' }, // field: string
//        ^?
        { field: 'b' }, // field: string
//        ^?
    ]
)

Workbench Repro

🙁 Actual behavior

The types of objects in the array nested through the spread operator is not inferred to be Test, as such inference begins from scratch, so the type of field in those objects becomes string (and is not detected to be 'a' | 'b' | 'c' which I specified in the interface), and a rather cryptic type error is shown:

Type '{ field: string; }' is not assignable to type 'Test'.
  Types of property 'field' are incompatible.
    Type 'string' is not assignable to type '"a" | "b" | "c"'.

I have also included an example with using the spread operator in a function call for completeness, it generates basically the same error.

I'm not sure if this is really a bug, but regardless, it is trivial to work around by just forcing compiler's hand a little by doing this:

let arr: Test[] = [
    { field: 'c' },
    ...[
        { field: 'a' as const },
        { field: 'b' as const },
    ]
]

Which forces the inferred types of the objects to actually be compatible, or assigning the spread array to a variable with an explicitly defined type:

let nested: Test[] = [
    { field: 'a' },
    { field: 'b' },
]
let arr: Test[] = [
    { field: 'c' },
    ...nested
]

🙂 Expected behavior

I would expect the type of expr3 in [expr1, expr2, ...expr3] to be inferred to be Iterable<T> or something like that provided that we know that the type of elements of the overall array is T. I believe that in my repro it would make types of nested objects to be inferred correctly as Test.

Guide contributeur