API: incorrect declarations in types.ts

(5 commentaires) (12 réactions) (0 personne assignée)TypeScript (13 395 forks)batch import

Breaking ChangeHelp WantedInfrastructure

Métriques du dépôt

The --strictNullChecks PR changed some declarations in types.ts to avoid frequent assertions in the compiler's code. Unfortunately these changes make it really unsafe for API users because they no longer contain the actually nullable types: https://github.com/Microsoft/TypeScript/pull/22088#discussion_r184149465 https://github.com/Microsoft/TypeScript/pull/22088#discussion_r184155027

ts.Node#parent is no longer optional (which is definitely wrong for SourceFile)
ts.Symbol#declarations and ts.Symbol.valueDeclaration are no longer optional, but can still be undefined
ts.Type#symbol is no longer optional, but I guess this comment is still up to date: // Symbol associated with type (if any)

These changes should either be reverted or replaced in the published declaration files. /cc @andy-ms @weswigham

Direction de recherche: Examinez le PR #22088 lié et les discussions pour comprendre les modifications incorrectes des types nullable dans types.ts. Envisagez de rétablir ou d'ajuster les déclarations pour restaurer le caractère optionnel des membres nullable.
Stack technique: typescript
Domaine: backendapi
Type d'issue: Bug
Difficulté: 3
Temps estimé: Une demi journée
Statut d'activité: Active
Clarté: Claire
Prérequis: TypeScript
Accessibilité débutant: 30