Refactor code and remove duplication
#7 318 ouverte le 15 avr. 2022
Métriques du dépôt
- Stars
- (12 822 étoiles)
- Métriques de merge PR
- (Merge moyen 3j 6h) (16 PRs mergées en 30 j)
Description
This task is about remove code duplication.
The skaffold filter command was added to apply debug transformations to configure container images for debugging.
See here -> https://skaffold.dev/docs/workflows/debug/#configuring-container-images-for-debugging
When skaffold filter command was added it did not need any information from the run context.
However, after @aaron-prindle added the Resource Selector config where users can configure which resource types to transform.
These list now needs to be passed to Filter command. In #7317, @tejal29 duplicated the functionality in getTransformList
The right way to do this is, Add Filter() method to the SkaffoldRunner which has access to the runner.RunContext.TransformAllowList and runCtx.runner.RunContext.TransformDenyList
The new Filter method will additionally execute the runFilter in here