FreshRSS/FreshRSS

[Bug] Actualize lock files in a multi instance environment share the same path

Fermée

#6 370 ouverte le 21 avr. 2024

 (5 commentaires) (0 réaction) (0 personne assignée)PHP (1 171 forks)batch import
Documentation :books:Good first issue 1️⃣Supporthelp wanted

Métriques du dépôt

Stars
 (15 022 étoiles)
Métriques de merge PR
 (Merge moyen 11j 12h) (36 PRs mergées en 30 j)

Description

Describe the bug

Current installed version 1.23.1

In multi installation setup on hosted server where I have little agency instances running actualize cron jobs at same time share actualize lock files. Causing failed actualize job for every other instance after the first.

app/actualize_script.php: $mutexFile = TMP_PATH . '/actualize.freshrss.lock';

I modified the "TMP_PATH . '/actualize.freshrss.lock';`" line to unique filenames per instance. And it solved my issue for now. However, I think this issue can cause problem for others.

To Reproduce

  1. Setup multiple instance.
  2. Setup cron actualize jobs to the same date.
  3. Check cron logs.
  4. See error in one: "FreshRSS feeds actualization was already running, so aborting new run..."

Expected behavior

Instances in the same environment installed different directory have different lock files.

FreshRSS version

Current installed version 1.23.1

Environment information

Installed on LAMP hosting service managed by Cpanel.

  • PHP 7.4+

Additional context

No response

Guide contributeur