FEniCS/dolfinx

Using exception subtypes

Ouverte

#2 398 ouverte le 7 oct. 2022

 (2 commentaires) (0 réaction) (0 personne assignée)C++ (255 forks)auto 404
enhancementgood first issuehousekeeping

Métriques du dépôt

Stars
 (1 158 étoiles)
Métriques de merge PR
 (Métriques PR en attente)

Description

SonarCloud complains about our exception throwing, and I think it makes sense:

If you throw a general exception type, such as std::exception, std::logic_error or std::runtime_error, it forces consumers to catch all exceptions, including unknown exceptions they don’t necessarily know how to handle.

Instead, either throw a subtype that already exists ( for example in ), or create your own type that derives from a standard one.

https://wiki.sei.cmu.edu/confluence/display/java/ERR07-J.+Do+not+throw+RuntimeException%2C+Exception%2C+or+Throwable

Guide contributeur