Doichain/dapp
Security: RPC-API-CALL sendrawtransaction needs validation
Ouverte
#116 ouverte le 29 oct. 2019
A prioritybountyenhancementgood first issuehelp wantedsecurity
Métriques du dépôt
- Stars
- (6 étoiles)
- Métriques de merge PR
- (Métriques PR en attente)
Description
When calling RPC-API sendrawtransaction please validate and limit the data given over the body parameters to prevent dDoS attacks.
This RPC-Call is located in: meteor-api package: https://github.com/Doichain/meteor-api inside file: server/api/rest/imports/send.js around line 639: Api.addRoute(DOICHAIN_BROADCAST_TX, { parameter*: !params.templateDataEncrypted || ... etc. is not yet limited. The size of this parameter (size of data) should be able to be limited in settings
The question here is if restivus (the REST API package of meteor) already has such capabilities or we must do it AFTER we received 1 GB of data. I think this could be already too late here.