Comfy-Org/ComfyUI_frontend
[DevTask]: Run browser tests on Windows runner
Ouverte
#3 197 ouverte le 23 mars 2025
enhancementhelp wanted
Métriques du dépôt
- Stars
- (1 838 étoiles)
- Métriques de merge PR
- (Merge moyen 4j 21h) (881 PRs mergées en 30 j)
Description
Is there an existing issue for this?
- I have searched the existing issues and checked the recent builds/commits
What would your feature do ?
When developer uses Unix, and CI tests also all use Unix, changes are never tested on Windows. Running browser tests on Windows container during CI tests would resolve this lack of coverage.
Proposed workflow
- The workflows from comfyanonymous/ComfyUI or Comfy-Org/desktop are used to setup ComfyUI server in Windows container
- The
chromiumPlaywright project is run in the Windows runner
Additional information
Issues that could potentially have been caught if a Playwright tests were run on Windows runner:
- https://github.com/comfyanonymous/ComfyUI/pull/4801
- https://github.com/Comfy-Org/ComfyUI_frontend/pull/2797
- https://github.com/Comfy-Org/ComfyUI_frontend/pull/3196
- https://github.com/Comfy-Org/ComfyUI_frontend/pull/2630
- https://github.com/comfyanonymous/ComfyUI/pull/4906 (maybe)
┆Issue is synchronized with this Notion page by Unito