Byron/trash-rs

[feat] Map Windows errors

Ouverte

#96 ouverte le 10 janv. 2024

 (6 commentaires) (0 réaction) (0 personne assignée)Rust (40 forks)auto 404
enhancementhelp wanted

Métriques du dépôt

Stars
 (247 étoiles)
Métriques de merge PR
 (Aucune PR mergée en 30 j)

Description

It appears that all windows::core::Error's are mapped to trash::Error::Unknown (code here). Is it possible to use the error code (ref) to map at least some of the more common errors to the corresponding trash::Error variant?

e.g. codes 2 and 3 could map to trash::Error::FileSystem with an error kind of std::io::ErrorKind::NotFound.

Another option could allow for the Unknown variant to also accept an optional error code, but that doesn't feel like the correct way to go about it.

Happy to give implementation a shot if it seems like a good idea.

Guide contributeur