fossasia/visdom

Properties box not updating

Closed

#693 opened on Dec 11, 2019

View on GitHubContributor guide
 (3 comments) (0 reactions) (1 assignee)Python (1,152 forks)batch import
bughelp wanted

Repository metrics

Stars
 (9,831 stars)
PR merge metrics
 (Avg merge 9d 12h) (116 merged PRs in 30d)

Description

Bug Description When I trigger an update with viz.properties(), the window does not update.

Reproduction Steps Enter steps to reproduce the behavior:

  1. In python, run viz.properties([...], win='mywin')
  2. Open visdom in the browser
  3. Update the window with viz.properties([...], win='mywin')
  4. The property window does not update
  5. Refresh the browser. The property window contains the correct data.

Expected behavior The property window should update with new values.

Screenshots N/A

Client logs: The javascript console shows a warning:

main.js?v=47fc3afa811b358b354df09184e392e7:19 Warning: validateDOMNesting(...): <tr> cannot appear as a child of <table>. Add a <tbody> to your code to match the DOM tree generated by the browser.

However, I tested a patched version with <tbody> and it still had the update bug, even though the warning went away. So it looks like this not an issue.

I added some console.log statements inside of the render() functions, and it looks like the pane is re-rendering with the correct values. Somehow that update is not being reflected in the DOM.

Server logs: N/A

Additional context Using Chrome 78.0.3904.108 on Mac. Using visdom 0.1.8.9

Contributor guide

Research direction
Investigate the React render function for the properties pane in main.js. The bug is likely related to how the component updates its state or how the DOM is reconciled. Check if there is a missing key prop or improper use of state. Also verify if the issue persists with newer versions of React or if it's a compatibility issue with the browser. Look at the console warning about <tr> nesting even though adding <tbody> didn't fix the update.
Tech stack
pythonjavascriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Basic React knowledgeJavaScript debugging
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50