fossasia/visdom

Visdom does not display when accessed via a proxy (with a path in its URL)

Open

#666 opened on Sep 6, 2019

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Python (9,831 stars) (1,152 forks)batch import
enhancementhelp wanted

Description

Bug Description I want to access visdom only via a proxy.

Visdom runs at the address 'http://visdomHost:8097' The proxy runs at the address 'http://proxyHost:8080/path1'. It receives requests at this address and redirects them to visdom.

The issue is that visdom cannot find static files because it does not consider/support the proxy path ('/path1'). In the browser console, I see that visdom is looking for the files 'http://proxyHost:8080/static/css/xxx', whereas the correct address is 'http://proxyHost:8080/path1/static/css/xxx'

How can I configure visdom to consider the path in the proxy URL.

Note that the proxy works fine when the path is simply '/'.

Thanks in advance.

Reproduction Steps

  1. Run visdom
  2. Configure a proxy (with a PATH in its URL) to redirect requests to visdom. For instance, you can configure nginx to redirect the path '/path1' to visdom.
  3. See the errors that appear in the browser console

Contributor guide

Tech stack
pythonjavascripthtmlcss
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
The issue is that Visdom's static files are served with an absolute path (e.g., /static/css/xxx) instead of a relative path that respects a proxy prefix. To fix this, look at how the static file routes are defined in the Visdom server (likely in server.py or a similar file). Consider using a configuration option or environment variable to set the base path for static files, and ensure all links in the HTML templates use that base path. The issue comments may contain hints; review them for suggested approaches.