fossasia/visdom

Use environment names in legend titles in environment comparison

Open

#401 opened on Jun 25, 2018

View on GitHub
 (3 comments) (1 reaction) (1 assignee)Python (9,831 stars) (1,152 forks)batch import
Fix Proposedenhancementhelp wanted

Description

Maybe there are considerations I'm not thinking of, but why not simply label '0_1' in the 'loss' comparison plot as 'expt1' instead (and '1_1' as 'expt2') in the screenshot below? Seems more convenient than cross-referencing the legend with the 'compare_legend' text box.

screen shot 2018-06-25 at 12 49 38 pm

Contributor guide

Tech stack
pythonnumpypytorch
Domain
frontenddata
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Python programming
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate how legend titles are generated in the environment comparison plots. Look for the function that creates plot labels in the Visdom source code. Modify it to use environment names instead of numeric codes. Check for existing tests and update them accordingly.