fortra/impacket

IP ToS is deprecated / no DSCP/ECN fields in IP class

Open

#211 opened on Sep 23, 2016

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (12,244 stars) (3,421 forks)batch import
enhancementhelp wanted

Description

The IP class should handle the differentiated services field (DSCP and ECN) similar to the traffic class in IPV6.

Contributor guide

Tech stack
python
Domain
backend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Python basicsnetworking fundamentals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Examine the IP class in impacket (likely in impacket/IP.py) to understand current handling of ToS. Look at the IPv6 traffic class implementation as a reference for adding DSCP (6 bits) and ECN (2 bits) fields. Implement the fields, ensuring backward compatibility with existing code. Check if any tests exist for the IP class and update them accordingly.