foam-framework/foam

Should clone() run initializers? ... probably by issuing a create()?

Open

#425 opened on Oct 8, 2015

View on GitHub
 (1 comment) (0 reactions) (1 assignee)JavaScript (789 stars) (57 forks)batch import
bughelp wantedquestion

Description

@jacksonic, @adamvy, and I were discussing this today. We've noted that dynamicValue() breaks init() doesn't run on objects that come out of a DAO that produces clones. We are pretty confident that this is because clone() doesn't actually create() a new object, and that it probably should.

@kgrgreer, can you offer your thoughts on this?

Contributor guide

Tech stack
javascript
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
needs maintainer response
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
Understanding of Foam object modelKnowledge of clone() and create() methods
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate the clone() method implementation in the FOAM framework, likely in files related to object creation and initialization. Review the discussion in the issue and any linked comments. Look at the dynamicValue() function to understand how it breaks when init() is not run. Consider modifying clone() to call create() under the hood to ensure initializers run. Consult maintainer @kgrgreer for acceptance criteria.