MatrixTransition.filterQuality doesn't outline performance implications if it is provided or null
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 72/100
- Issue type
- Documentation
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- dart
- Domain
- documentation
Research direction
Start at the MatrixTransition.filterQuality API documentation and inspect the related implementation to establish what happens when the value is null versus provided. Update the documentation to explain when the child is re-rendered, the performance implications, and how the setting affects layer structure; done means readers can tell when to use each option.
Written by the indexing model from the issue text.
Description
The documentation for MatrixTransition.filterQuality says:
The transform will be applied by re-rendering the child if filterQuality is null, otherwise it controls the quality of an ImageFilter.matrix applied to a bitmap rendering of the child.
But it is not clear when/how often the child is re-rendered if null, or what the performance implications of that are, or how setting it affects the layer structure. So it can be non-obvious to a reader when to set it and when not to.
This came up in reviewing this PR which sets it to null for platform views.
- Dominant language
- Dart
- Stars
- 179k
- Forks
- 31.7k
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 413
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from flutter/flutter
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
c: tech-debt package team-ecosystem
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
waiting for response
Difficulty 1/5 1-3 hours Newbie friendliness 88/100
-
waiting for response
Difficulty 1/5 Under an hour Newbie friendliness 88/100
-
material_ui 1.3.0 & cupertino_ui 1.1.0 on Flutter 3.44 Error: Undefined name 'awaitNotRequired'. Openp: cupertino_ui p: material_ui package team-design
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
code quality good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Suwayomi/Suwayomi-Tsumiru#479 ·
-
Build Failure: agora_rtc_engine compiled against android-31 while dependencies require android-34+ Open
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 92/100
conceptadev/noir#95 ·