flutter/flutter

Respect flutter::Settings from command line arguments specified to test harnesses.

Open

#134,471 opened on Sep 11, 2023

View on GitHub
 (9 comments) (0 reactions) (0 assignees)Dart (30,366 forks)batch import
P2c: tech-debtgood first issueteam-enginetriaged-engine

Repository metrics

Stars
 (176,322 stars)
PR merge metrics
 (Avg merge 7d 7h) (491 merged PRs in 30d)

Description

In //flutter/common, there are flutter::Settings in switches.h that can be read from the command line (via flutter::SettingsFromCommandLine). However, these settings are not respected in any of the test harnesses in //flutter/testing. Now, not all the settings are valid in unit-tests. So these likely need to be split apart into base settings for all exectuables. But stuff like log control, log tags, and such should be configurable from the command line in unit-tests.

Contributor guide

Research direction
Examine the flutter::Settings struct in switches.h and the SettingsFromCommandLine function. Identify which settings are relevant to test harnesses. Consider splitting the settings into base and test specific categories. Look at existing test harness entry points to integrate the command line parsing.
Tech stack
cpp
Domain
testing
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
C++Flutter testing infrastructure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40