Fluent::Logger::TestLogger.open returns a Fluent::Logger::FluentLogger instance

Open
#17 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
ruby
Domain
backend

Research direction

Start by comparing Fluent::Logger::TestLogger.open in fluent-logger 0.4.7 and 0.4.8, then read commit 2068b446 and the discussion in issue #10. Determine whether returning FluentLogger is intentional or a regression; done means the expected return type is documented or corrected and verified against the relevant behavior.

Written by the indexing model from the issue text.

Description

At fluent-logger 0.4.7, Fluent::Logger::TestLogger.open returns a Fluent::Logger::TestLogger instance.
At fluent-logger 0.4.8, it returns a Fluent::Logger::FluentLogger instance.
It's caused by https://github.com/fluent/fluent-logger-ruby/commit/2068b4468025482306ecc587d383903dc1454ff9 discussed in #10.

Is it an intended change?

Dominant language
Ruby
Stars
256
Forks
77
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from fluent/fluent-logger-ruby

All issues in fluent/fluent-logger-ruby

Similar issues

More Ruby issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.