Trouble with millisecond (or any sub-second) resolution (outdated protocol implementation?)

Open
#165 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
38/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript

Research direction

Start with the related implementation from issue #47 and compare its timestamp handling against the Fluentd Forward Protocol Specification v1 linked in the report. Reproduce the reported behavior with second, millisecond, and nanosecond resolution. Done means sub-second timestamps produce valid dates while second-resolution behavior continues to work.

Written by the indexing model from the issue text.

Description

First, thanks for maintaining this module.

Then, it appears to have trouble with getting sub-second resolution right, and it may be because the last update of the related code (#47, 2016) doesn't seem to conform to the current fluentd spec (https://github.com/fluent/fluentd/wiki/Forward-Protocol-Specification-v1, 2017).

I've checked this with a new project having the most recent versions of everything:

  • second resolution works fine
  • millisecond resolution yields invalid dates
  • fluentd is barely configured
  • other components (e.g. a ruby one with a "standard" client lib) perform as expected (with nanosecond resolution).

I believe it's a quick fix for @sveneh or @okkez or other people doing great job here.

Dominant language
JavaScript
Stars
258
Forks
82
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from fluent/fluent-logger-node

All issues in fluent/fluent-logger-node

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.