`TimeoutOverflowWarning` after many retries
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 48/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- node.js, typescript
- Domain
- networking
Research direction
Start with the linked retry logic in src/socket.ts and src/event_retrier.ts, focusing on the maxDelay default and the computed value passed to setTimeout. Reproduce the behavior after many retries and verify that delays above the 32-bit signed integer limit no longer trigger a TimeoutOverflowWarning or become 1 millisecond.
Written by the indexing model from the issue text.
Description
The maxDelay parameter defaults to Infinity:
https://github.com/fluent/fluent-logger-forward-node/blob/937ad65703067cad762570c2e60fad4c6262255c/src/socket.ts#L323
https://github.com/fluent/fluent-logger-forward-node/blob/937ad65703067cad762570c2e60fad4c6262255c/src/event_retrier.ts#L57
In the case where the computed delay is larger than the maximum 32-bit signed integer (2 ** 31 - 1), a TimeoutOverflowWarning is emitted by setTimeout, the value 1 is assumed, and we end up waiting only 1 millisecond before retrying, which causes frequent retries.
I have worked around this issue by passing:
socket: {
reconnect: {
maxDelay: 2 ** 31 - 1
}
}
- Dominant language
- TypeScript
- Stars
- 12
- Forks
- 7
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from fluent/fluent-logger-forward-node
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
fluent/fluent-logger-forward-node#46 · 3 comments · 1 reaction ·
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
fluent/fluent-logger-forward-node#40 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
fluent/fluent-logger-forward-node#32 · 6 comments ·
All issues in fluent/fluent-logger-forward-node
Similar issues
-
bug(cli): hapi doctor inline-media prints a fabricated B:\ helper-script path in packaged installs Open
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
Crush Open
Difficulty 1/5 Under an hour Newbie friendliness 85/100
catppuccin/catppuccin#3125 ·
-
Add a SECURITY.md Open
Difficulty 1/5 Under an hour Newbie friendliness 90/100
ElementsProject/cln-application#167 · 1 comment · 1 reaction ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Quantco/pnpm-licenses#17 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100