flipace/react-themeit

refs can't be set on stateless components

Open

#9 opened on Nov 9, 2017

View on GitHub
 (0 comments) (0 reactions) (2 assignees)JavaScript (2 forks)github user discovery
bugenhancementhelp wanted

Repository metrics

Stars
 (28 stars)
PR merge metrics
 (PR metrics pending)

Description

When using themeit with react 16 on a stateless component react will log an error about stateless components not supporting refs (ofc). Themeit should check the component type before adding the ref prop.

Contributor guide

Research direction
Inspect the component type before adding the ref prop. Determine if the component is a stateless functional component and conditionally omit the ref.
Tech stack
javascriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ReactJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70