flipace/horizon-react

Error responses from websocket are swallowed

Open

#14 opened on Jul 28, 2016

View on GitHub
 (2 comments) (0 reactions) (1 assignee)JavaScript (5 forks)github user discovery
bugenhancementhelp wanted

Repository metrics

Stars
 (112 stars)
PR merge metrics
 (PR metrics pending)

Description

At the moment websocket error responses get swallowed and I have to manually inspect the messages to see what's wrong.

I've attempted to do:

collection.update(formData).subscribe(
  (d) => console.log('DONE', d),
  (err) => console.error(err),
)

Within my client code and changing https://github.com/flipace/horizon-react/blob/0806ede99abd4153117d6191dc10f9cce5bfbd20/src/components/subscribe.js#L206 to:


this.subscriptions[name] = {
  subscription: query
    .watch()
    .subscribe(
      this.handleData.bind(this, name),
      err => console.error(err)
    }),
  query: query._query
};

Neither of these will receive the error response. It's also not received by handleData (https://github.com/flipace/horizon-react/blob/0806ede99abd4153117d6191dc10f9cce5bfbd20/src/components/subscribe.js#L221)

Any guidance on how to go about this would be appreciated.

Contributor guide

Research direction
Investigate how the subscribe method handles errors by tracing the websocket event handling in the horizon react library, particularly the watch() method and the subscribe() callback chain. Check if errors are being caught and passed to the error callback.
Tech stack
javascriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptReactwebsocket
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65