App logs to stderr "Warning: 'ms-enable-electron-run-as-node' is not in the list of known options, but still passed to Electron/Chromium."
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 65/100
Research direction
Inspect code.sh at lines 69-70, where the Electron launch arguments are assembled. Remove the obsolete option as described, then run the application and verify that stderr no longer contains the known-options warning.
Written by the indexing model from the issue text.
Description
When running this application, the above is written to stderr, which seems to be because this option is no longer supported by vscode as of Chromium v29, which upstream began using in May last year. I believe the following change can be made in these lines (https://github.com/flathub/com.visualstudio.code/blob/e0e3f21b28330f31729e7b6eed5341d5e4390f0e/code.sh#L69-L70):
- --ms-enable-electron-run-as-node --extensions-dir=${XDG_DATA_HOME}/vscode/extensions \
- "$@" ${WARNING_FILE}
+ --extensions-dir=${XDG_DATA_HOME}/vscode/extensions "$@" ${WARNING_FILE}
This could be achieved by applying the above diff, or by simply reverting ad2d7c8edbf45d7e9e6a779d2e5a72c1761a6491, which added the now-defunct option.
- Dominant language
- Shell
- Stars
- 216
- Forks
- 82
- Avg merge
- 1d 7h
- Merged PRs (30d)
- 1
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from flathub/com.visualstudio.code
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
flathub/com.visualstudio.code#679 · 4 comments ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
flathub/com.visualstudio.code#388 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 55/100
flathub/com.visualstudio.code#715 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
flathub/com.visualstudio.code#710 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 32/100
flathub/com.visualstudio.code#698 ·
All issues in flathub/com.visualstudio.code
Similar issues
-
Bob Shell support Openenhancement
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
-
tooling
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
openSUSE/python-rpm-macros#219 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
YunoHost-Apps/adguardhome_ynh#258 ·
-
steam-short-session-tracker: incorrect registry backup path resets settings during automatic repair Open
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
ValveSoftware/SteamOS#2829 ·