flameshot-org/flameshot

Improvement to the pin tool

Open

#954 opened on Sep 21, 2020

View on GitHub
 (22 comments) (26 reactions) (0 assignees)C++ (1,916 forks)batch import
EnhancementHelp Wanted

Repository metrics

Stars
 (29,897 stars)
PR merge metrics
 (Avg merge 2d 23h) (12 merged PRs in 30d)

Description

Currently flameshot provides a simple implementation of image pinning. However, this implementation is quite simple. Once the image is pinned, it floats at the top of the desktop and can be dragged around, but that's basically everything. In order to close this pinned image, one will have to use the "Esc" key or double click on the image. Otherwise the only possible way is to close from the window list. This is not friendly to tablet users who have limited access to the keyboard.

I think the following improvements can be made:

  • Allow right click on the pinned image; a menu should pop out giving options to close the pinned image or save it as an image file on disk.
  • Document the usage of pin tool somewhere. I doubt users ever know the behavior of "double click to close".

Contributor guide

Research direction
Examine the existing pin tool source code to understand how the pinned image window is created and managed. Then implement a right click context menu with options to close and save the pinned image, and update documentation to mention double click to close.
Tech stack
cpp
Domain
desktop
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Qt
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80