flameshot-org/flameshot

SVG optimization made some icons unreadable

Open

#3,247 opened on Jun 28, 2023

View on GitHub
 (3 comments) (0 reactions) (0 assignees)C++ (1,916 forks)batch import
BugHelp WantedVisuals

Repository metrics

Stars
 (29,897 stars)
PR merge metrics
 (Avg merge 2d 23h) (12 merged PRs in 30d)

Description

While trying to use some of the SVGs created for buttons on the webpage, I realized the img/buttonIconsBlack/square.svg with following code does not render in Firefox:

https://github.com/flameshot-org/flameshot/blob/236534b17b0318b05b4e28bb906c38c78bae84de/data/img/material/black/square.svg#L1C1-L3C7 :

<svg viewBox="0 0 24 24">
    <path d="M3,3V21H21V3"/>
</svg>

But the same file before the #281 (commit d09580b) with the following content work just fine:

<?xml version="1.0" encoding="UTF-8"?><!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd"><svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" version="1.1" width="24" height="24" viewBox="0 0 24 24"><path d="M3,3V21H21V3" /></svg>

The working icon: , the broken icon:

There are two SVG files in the line above but one of them is rendered in the browser. View page source to confirm.

Contributor guide

Research direction
Compare the optimized SVG file with the original to identify missing attributes (like namespace, version, width/height) and add them back to make the SVG render correctly in all browsers.
Tech stack
None
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
SVGGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90