flameshot-org/flameshot

Deletaion for active tool does not work

Open

#3,228 opened on Jun 12, 2023

View on GitHub
 (9 comments) (0 reactions) (0 assignees)C++ (29,897 stars) (1,916 forks)batch import
EnhancementGood first issue

Description

Flameshot Version

Flameshot v11.0.0 (11.0.0-2 Debian) Compiled with Qt 5.15.2

Installation Type

Linux, MacOS, or Windows Package manager (apt, pacman, eopkg, choco, brew, ...)

Operating System type and version

Linux Mint v21.1 Cinnamon

Description

I tried to

image

Steps to reproduce

  1. run flameshot gui
  2. Select tool c
  3. Try to delete current tool Del

If you press Esc it deselects current tool though.

Screenshots or screen recordings

dd

System Information

Linux Mint v21.1 Cinnamon

System: Host: kes-X406UA Kernel: 5.15.0-73-generic x86_64 bits: 64 Desktop: Cinnamon 5.6.8 Distro: Linux Mint 21.1 Vera Graphics: Device-1: Intel HD Graphics 620 driver: i915 v: kernel Device-2: IMC Networks USB2.0 HD UVC WebCam type: USB driver: uvcvideo Display: x11 server: X.Org v: 1.21.1.4 driver: X: loaded: modesetting unloaded: fbdev,vesa gpu: i915 resolution: 1920x1080~60Hz OpenGL: renderer: Mesa Intel HD Graphics 620 (KBL GT2) v: 4.6 Mesa 22.2.5

Contributor guide

Tech stack
cpp
Domain
desktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic C++Qt event handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate key press event handling in the capture widget, particularly the logic for deleting the active tool. Look for how the 'Esc' key deselects and why 'Del' does not. Review the comment thread for any additional context or partial solutions.